Skip to content

Wait for Guardian score progress in approval tests - #39007

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/3d92c9a3ccf52f4f43a2454aac60d2479258c1c8
Aug 17, 2026
Merged

Wait for Guardian score progress in approval tests#39007
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/3d92c9a3ccf52f4f43a2454aac60d2479258c1c8

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 17, 2026

Copy link
Copy Markdown

Wait for Guardian score progress in approval tests

Why

Guardian stores a SecurityRiskScore before advancing its scored-tool-call
counter. Waiting only for the score can therefore let the test continue while
the asynchronous sampler is still updating its progress state.

What changed

Wait for latest_scored_tool_call to advance before exercising Guardian v2
approval decisions, and reuse the same progress tracker for the subsequent
assertions.

## Why

Guardian stores a `SecurityRiskScore` before advancing its scored-tool-call
counter. Waiting only for the score can therefore let the test continue while
the asynchronous sampler is still updating its progress state.

## What changed

Wait for `latest_scored_tool_call` to advance before exercising Guardian v2
approval decisions, and reuse the same progress tracker for the subsequent
assertions.

GitOrigin-RevId: 3d92c9a3ccf52f4f43a2454aac60d2479258c1c8
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/3d92c9a3ccf52f4f43a2454aac60d2479258c1c8 branch from 38076ef to def7ed5 Compare August 17, 2026 13:27
@copyberry
copyberry Bot merged commit def7ed5 into main Aug 17, 2026
28 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/3d92c9a3ccf52f4f43a2454aac60d2479258c1c8 branch August 17, 2026 13:28
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant