Avoid redundant terminal row clears - #39075
Merged
copyberry[bot] merged 1 commit intoAug 17, 2026
Merged
Conversation
## Why The custom TUI buffer diff emitted `ClearToEnd` for unchanged trailing blank regions, producing unnecessary terminal output. ## What changed - Clear a row tail only when its cached contents changed or a wide glyph overlaps the clear boundary. - Keep blank cells marked `AlwaysUpdate` in the drawable region so viewport invalidation still forces them to repaint. - Preserve Ratatui's native cell diff behavior for the remaining updates. ## Testing Add coverage for unchanged row tails, forced blank-cell updates, and shrinking wide graphemes, including half-width katakana with combining marks. GitOrigin-RevId: a9cac06f5624032a2b8c80a66c651cf3e85ec7fb
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/a9cac06f5624032a2b8c80a66c651cf3e85ec7fb
branch
from
August 17, 2026 20:44
ad40c64 to
37efa18
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/a9cac06f5624032a2b8c80a66c651cf3e85ec7fb
branch
August 17, 2026 20:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid redundant terminal row clears
Why
The custom TUI buffer diff emitted
ClearToEndfor unchanged trailing blankregions, producing unnecessary terminal output.
What changed
the clear boundary.
AlwaysUpdatein the drawable region so viewportinvalidation still forces them to repaint.
Testing
Add coverage for unchanged row tails, forced blank-cell updates, and shrinking
wide graphemes, including half-width katakana with combining marks.