Skip to content

Decouple Noise relay streams from JSON-RPC processing - #39235

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/270befcc8bfbf27e46c84d6a2c6e349cb98ea3f8
Aug 18, 2026
Merged

Decouple Noise relay streams from JSON-RPC processing#39235
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/270befcc8bfbf27e46c84d6a2c6e349cb98ea3f8

Conversation

@copyberry

@copyberry copyberry Bot commented Aug 18, 2026

Copy link
Copy Markdown

Decouple Noise relay streams from JSON-RPC processing

What changed

  • Add a NoiseStreamHandler abstraction that owns payload encoding, decoding,
    and connection processing while the virtual stream handles framing,
    encryption, and multiplexing.
  • Reassemble authenticated payloads as opaque bytes, with the existing
    JSON-RPC processor supplied as a handler implementation.
  • Have the physical relay send a reset after the current stream instance
    closes, including when its processor exits before the writer task.

Testing

  • Verify local JSON-RPC decoding creates the queued request span before queue
    admission.
  • Verify a processor exit resets the corresponding Noise harness stream.

## What changed

- Add a `NoiseStreamHandler` abstraction that owns payload encoding, decoding,
  and connection processing while the virtual stream handles framing,
  encryption, and multiplexing.
- Reassemble authenticated payloads as opaque bytes, with the existing
  JSON-RPC processor supplied as a handler implementation.
- Have the physical relay send a reset after the current stream instance
  closes, including when its processor exits before the writer task.

## Testing

- Verify local JSON-RPC decoding creates the queued request span before queue
  admission.
- Verify a processor exit resets the corresponding Noise harness stream.

GitOrigin-RevId: 270befcc8bfbf27e46c84d6a2c6e349cb98ea3f8
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/270befcc8bfbf27e46c84d6a2c6e349cb98ea3f8 branch from 054f055 to 3df5087 Compare August 18, 2026 17:20
@copyberry
copyberry Bot merged commit 3df5087 into main Aug 18, 2026
27 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/270befcc8bfbf27e46c84d6a2c6e349cb98ea3f8 branch August 18, 2026 17:21
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 18, 2026
@dgwyer
dgwyer deployed to issue-triage August 18, 2026 17:23 — with GitHub Actions Active
@dgwyer
dgwyer deployed to issue-triage August 18, 2026 17:23 — with GitHub Actions Active
@dgwyer
dgwyer deployed to issue-triage August 18, 2026 17:23 — with GitHub Actions Active
@sunnyboyChou
sunnyboyChou deployed to issue-triage August 18, 2026 17:25 — with GitHub Actions Active
@sunnyboyChou
sunnyboyChou deployed to issue-triage August 18, 2026 17:25 — with GitHub Actions Active
@sunnyboyChou
sunnyboyChou deployed to issue-triage August 18, 2026 17:25 — with GitHub Actions Active
@rcwells1879
rcwells1879 deployed to issue-triage August 18, 2026 17:31 — with GitHub Actions Active
@rcwells1879
rcwells1879 deployed to issue-triage August 18, 2026 17:31 — with GitHub Actions Active
@rcwells1879
rcwells1879 deployed to issue-triage August 18, 2026 17:31 — with GitHub Actions Active
@rcwells1879
rcwells1879 deployed to issue-triage August 18, 2026 17:32 — with GitHub Actions Active
@shaded0
shaded0 deployed to issue-triage August 18, 2026 17:41 — with GitHub Actions Active
@shaded0
shaded0 deployed to issue-triage August 18, 2026 17:41 — with GitHub Actions Active
@shaded0
shaded0 deployed to issue-triage August 18, 2026 17:41 — with GitHub Actions Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants