Prevent apply_patch from widening write permissions - #39614
Merged
copyberry[bot] merged 1 commit intoAug 20, 2026
Merged
Conversation
## Why Deriving permissions from the parent of an already-writable patch target can unnecessarily grant write access outside the intended workspace. ## What changed Skip targets already covered by the active filesystem sandbox policy before deriving additional parent-directory permissions. Targets outside the writable area continue to request the required parent access. ## Testing Added unit and CLI regression coverage for workspace-directory targets, already-writable parents, and symlink escapes outside the workspace. GitOrigin-RevId: 187109ff0b56a1a399cb8a9981b7e822977025d5
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/187109ff0b56a1a399cb8a9981b7e822977025d5
branch
from
August 20, 2026 06:22
a809a2b to
530c1ae
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/187109ff0b56a1a399cb8a9981b7e822977025d5
branch
August 20, 2026 06:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent
apply_patchfrom widening write permissionsWhy
Deriving permissions from the parent of an already-writable patch target can
unnecessarily grant write access outside the intended workspace.
What changed
Skip targets already covered by the active filesystem sandbox policy before
deriving additional parent-directory permissions. Targets outside the writable
area continue to request the required parent access.
Testing
Added unit and CLI regression coverage for workspace-directory targets,
already-writable parents, and symlink escapes outside the workspace.