Skip to content

Honor app link settings for MCP tool approvals - #42056

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/caa07ec3e73c87aad9522bd69808cd1c0b1686f5
Sep 1, 2026
Merged

Honor app link settings for MCP tool approvals#42056
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/caa07ec3e73c87aad9522bd69808cd1c0b1686f5

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 1, 2026

Copy link
Copy Markdown

Honor app link settings for MCP tool approvals

What changed

  • Pass the resolved app link_id into MCP tool approval policy evaluation.
  • Apply link-specific default_tools_approval_mode and approvals_reviewer
    settings before app and global defaults, while preserving per-tool and managed
    policy precedence.

Testing

  • Cover link-specific approval prompts, selected account links, reviewer
    routing, fallback behavior, and managed-policy overrides.

## What changed

- Pass the resolved app `link_id` into MCP tool approval policy evaluation.
- Apply link-specific `default_tools_approval_mode` and `approvals_reviewer`
  settings before app and global defaults, while preserving per-tool and managed
  policy precedence.

## Testing

- Cover link-specific approval prompts, selected account links, reviewer
  routing, fallback behavior, and managed-policy overrides.

GitOrigin-RevId: caa07ec3e73c87aad9522bd69808cd1c0b1686f5
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/caa07ec3e73c87aad9522bd69808cd1c0b1686f5 branch from 7f9a035 to 3a04482 Compare September 1, 2026 13:44
@copyberry
copyberry Bot merged commit 3a04482 into main Sep 1, 2026
27 of 33 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/caa07ec3e73c87aad9522bd69808cd1c0b1686f5 branch September 1, 2026 13:45
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 1, 2026
@Formatian
Formatian deployed to issue-triage September 1, 2026 14:21 — with GitHub Actions Active
@Formatian
Formatian deployed to issue-triage September 1, 2026 14:21 — with GitHub Actions Active
@Formatian
Formatian deployed to issue-triage September 1, 2026 14:21 — with GitHub Actions Active
@lips0127
lips0127 deployed to issue-triage September 1, 2026 14:27 — with GitHub Actions Active
@lips0127
lips0127 deployed to issue-triage September 1, 2026 14:27 — with GitHub Actions Active
@lips0127
lips0127 deployed to issue-triage September 1, 2026 14:27 — with GitHub Actions Active
@ca1tshame
ca1tshame deployed to issue-triage September 1, 2026 14:31 — with GitHub Actions Active
@ca1tshame
ca1tshame deployed to issue-triage September 1, 2026 14:31 — with GitHub Actions Active
@ca1tshame
ca1tshame deployed to issue-triage September 1, 2026 14:31 — with GitHub Actions Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants