Skip to content

Record result sources in app tool analytics - #42164

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7d5e394219eb33e0ab7b6db3f039138a78569d17
Sep 2, 2026
Merged

Record result sources in app tool analytics#42164
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/7d5e394219eb33e0ab7b6db3f039138a78569d17

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 2, 2026

Copy link
Copy Markdown

Record result sources in app tool analytics

What changed

  • Add per-tool analytics_result_source requirements, with support for the
    detailed_message_search_v1 format and normal configuration precedence.
  • Attach host-generated source IDs from accepted app tool results to recorded
    executed tool calls for both direct and Code Mode invocations.
  • Bound and deduplicate source metadata, reject caller-supplied values, and
    shed optional source data before dropping tool-call or completion metadata.
  • Preserve source updates across waits and retries while preventing stale or
    compacted records from overwriting accepted metadata.

Testing

Add coverage for requirement parsing and merging, trusted source snapshots,
metadata budgets, retries, waits, and compaction.

## What changed

- Add per-tool `analytics_result_source` requirements, with support for the
  `detailed_message_search_v1` format and normal configuration precedence.
- Attach host-generated source IDs from accepted app tool results to recorded
  executed tool calls for both direct and Code Mode invocations.
- Bound and deduplicate source metadata, reject caller-supplied values, and
  shed optional source data before dropping tool-call or completion metadata.
- Preserve source updates across waits and retries while preventing stale or
  compacted records from overwriting accepted metadata.

## Testing

Add coverage for requirement parsing and merging, trusted source snapshots,
metadata budgets, retries, waits, and compaction.

GitOrigin-RevId: 7d5e394219eb33e0ab7b6db3f039138a78569d17
@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/7d5e394219eb33e0ab7b6db3f039138a78569d17 branch from 678ae9d to 12ed76b Compare September 2, 2026 01:07
@copyberry
copyberry Bot merged commit 12ed76b into main Sep 2, 2026
21 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/7d5e394219eb33e0ab7b6db3f039138a78569d17 branch September 2, 2026 01:08
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 2, 2026
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:13 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:13 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:13 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:14 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:31 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:31 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:31 — with GitHub Actions Active
@AriaMaz
AriaMaz deployed to issue-triage September 2, 2026 01:32 — with GitHub Actions Active
@PNWGMR
PNWGMR deployed to issue-triage September 2, 2026 01:38 — with GitHub Actions Active
@PNWGMR
PNWGMR deployed to issue-triage September 2, 2026 01:38 — with GitHub Actions Active
@PNWGMR
PNWGMR deployed to issue-triage September 2, 2026 01:38 — with GitHub Actions Active
@PNWGMR
PNWGMR deployed to issue-triage September 2, 2026 01:40 — with GitHub Actions Active
@OnTheWayx2
OnTheWayx2 deployed to issue-triage September 2, 2026 01:46 — with GitHub Actions Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants