Require Guardian review for incompatible compaction checkpoints - #42588
Merged
copyberry[bot] merged 1 commit intoSep 3, 2026
Conversation
## Why Guardian can reuse an opaque parent compaction only when the checkpoint's recorded producer hash matches the scoring model. Missing or incompatible provenance must not allow an asynchronous score or cached approval to omit compacted context. ## What changed - Record the producing model's compatibility hash on compaction history items and expose the latest checkpoint hash through conversation snapshots. - In thread-owned context mode, fail closed and require synchronous review when checkpoint reuse is enabled but the latest checkpoint is incompatible or has unknown provenance. - Reject incompatible checkpoints in the sampler while preserving the legacy context behavior. ## Testing Add coverage for local, remote, resumed, compacted, and rolled-back histories, including matching, mismatched, missing, and empty compatibility hashes. GitOrigin-RevId: 1ce959cb276edc602fd7dfa442133c7fe5e53857
copyberry
Bot
force-pushed
the
copyberry/codex-internal-to-codex-oss/1ce959cb276edc602fd7dfa442133c7fe5e53857
branch
from
September 3, 2026 17:49
8e4101c to
ad8ee16
Compare
copyberry
Bot
deleted the
copyberry/codex-internal-to-codex-oss/1ce959cb276edc602fd7dfa442133c7fe5e53857
branch
September 3, 2026 17:50
RebeccaCode
temporarily deployed
to
issue-triage
September 3, 2026 17:54 — with
GitHub Actions
Inactive
RebeccaCode
temporarily deployed
to
issue-triage
September 3, 2026 17:54 — with
GitHub Actions
Inactive
RebeccaCode
temporarily deployed
to
issue-triage
September 3, 2026 17:54 — with
GitHub Actions
Inactive
RebeccaCode
temporarily deployed
to
issue-triage
September 3, 2026 17:55 — with
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Require Guardian review for incompatible compaction checkpoints
Why
Guardian can reuse an opaque parent compaction only when the checkpoint's
recorded producer hash matches the scoring model. Missing or incompatible
provenance must not allow an asynchronous score or cached approval to omit
compacted context.
What changed
and expose the latest checkpoint hash through conversation snapshots.
checkpoint reuse is enabled but the latest checkpoint is incompatible or has
unknown provenance.
context behavior.
Testing
Add coverage for local, remote, resumed, compacted, and rolled-back histories,
including matching, mismatched, missing, and empty compatibility hashes.