Skip to content

Add TUI building blocks for inline async question editing - #42889

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/4098043cf588ddafc05c27505645495edd690cb9
Sep 4, 2026
Merged

Add TUI building blocks for inline async question editing#42889
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/4098043cf588ddafc05c27505645495edd690cb9

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 4, 2026

Copy link
Copy Markdown

Add TUI building blocks for inline async question editing

What changed

  • Introduce an async-question editor component with per-question drafts, navigation, replay deduplication, and submit or queue handling using the shared composer.
  • Add bounded AnsweredQuestion framing that truncates question text at a UTF-8 boundary and flattens line breaks before prepending it to an answer.
  • Add prompt_stack_back and skip_question keybinding actions and the tui.question_esc_back setting. Normalize Ctrl+] and Ctrl+5 for key matching and conflict detection, and let default question shortcuts yield to explicit bindings.
  • Flush buffered typing in both the main composer and the covering view so background input cannot keep the draw loop waiting.

The async-question component is not yet connected to the TUI event flow.

Testing

Add regression coverage for bounded Unicode question framing, question-shortcut conflicts, and paste-buffer flushing in background and covering editors.

## What changed

- Introduce an async-question editor component with per-question drafts, navigation, replay deduplication, and submit or queue handling using the shared composer.
- Add bounded `AnsweredQuestion` framing that truncates question text at a UTF-8 boundary and flattens line breaks before prepending it to an answer.
- Add `prompt_stack_back` and `skip_question` keybinding actions and the `tui.question_esc_back` setting. Normalize `Ctrl+]` and `Ctrl+5` for key matching and conflict detection, and let default question shortcuts yield to explicit bindings.
- Flush buffered typing in both the main composer and the covering view so background input cannot keep the draw loop waiting.

The async-question component is not yet connected to the TUI event flow.

## Testing

Add regression coverage for bounded Unicode question framing, question-shortcut conflicts, and paste-buffer flushing in background and covering editors.

GitOrigin-RevId: 4098043cf588ddafc05c27505645495edd690cb9
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/4098043cf588ddafc05c27505645495edd690cb9 branch from 0c890a1 to 6ae8dcf Compare September 4, 2026 23:57
@copyberry
copyberry Bot merged commit 6ae8dcf into main Sep 4, 2026
24 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/4098043cf588ddafc05c27505645495edd690cb9 branch September 4, 2026 23:58
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants