Skip to content

Add inline Other answers to async question choices - #42897

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0e9aa9fcd2410e8da25f5ca43bdef94cbb9253b8
Sep 5, 2026
Merged

Add inline Other answers to async question choices#42897
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/0e9aa9fcd2410e8da25f5ca43bdef94cbb9253b8

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 5, 2026

Copy link
Copy Markdown

Add inline Other answers to async question choices

Why

Async questions with suggested choices only accepted those choices. Allow users to write an alternative answer directly in the question pane.

What changed

  • Append an editable Other choice. Typing or pasting opens it, while number shortcuts still submit named choices.
  • Preserve custom drafts when switching choices, reject blank Other submissions, and distinguish the input from a suggested choice named Other.
  • Support Vim editing and search in question inputs while keeping arrow keys available for choice navigation.
  • Wrap custom answers inline, cap the editor height, and keep the input visible in narrow layouts.

Testing

Add interaction tests and snapshots covering custom answer delivery, draft preservation, selector key repeats, blank answers, remapped shortcuts, Vim editing and search, and narrow or wrapped layouts.

## Why

Async questions with suggested choices only accepted those choices. Allow users to write an alternative answer directly in the question pane.

## What changed

- Append an editable Other choice. Typing or pasting opens it, while number shortcuts still submit named choices.
- Preserve custom drafts when switching choices, reject blank Other submissions, and distinguish the input from a suggested choice named Other.
- Support Vim editing and search in question inputs while keeping arrow keys available for choice navigation.
- Wrap custom answers inline, cap the editor height, and keep the input visible in narrow layouts.

## Testing

Add interaction tests and snapshots covering custom answer delivery, draft preservation, selector key repeats, blank answers, remapped shortcuts, Vim editing and search, and narrow or wrapped layouts.

GitOrigin-RevId: 0e9aa9fcd2410e8da25f5ca43bdef94cbb9253b8
@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/0e9aa9fcd2410e8da25f5ca43bdef94cbb9253b8 branch from 5623bed to c126b0d Compare September 5, 2026 00:50
@copyberry
copyberry Bot merged commit c126b0d into main Sep 5, 2026
25 of 32 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/0e9aa9fcd2410e8da25f5ca43bdef94cbb9253b8 branch September 5, 2026 00:51
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 5, 2026
@Doknes
Doknes deployed to issue-triage September 5, 2026 00:52 — with GitHub Actions Active
@Doknes
Doknes deployed to issue-triage September 5, 2026 00:52 — with GitHub Actions Active
@Doknes
Doknes deployed to issue-triage September 5, 2026 00:52 — with GitHub Actions Active
@Doknes
Doknes deployed to issue-triage September 5, 2026 00:53 — with GitHub Actions Active
@tqsoft888
tqsoft888 deployed to issue-triage September 5, 2026 00:54 — with GitHub Actions Active
@tqsoft888
tqsoft888 deployed to issue-triage September 5, 2026 00:54 — with GitHub Actions Active
@tqsoft888
tqsoft888 deployed to issue-triage September 5, 2026 00:54 — with GitHub Actions Active
@tqsoft888
tqsoft888 deployed to issue-triage September 5, 2026 00:55 — with GitHub Actions Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants