Skip to content

Enable MCP user verification in the TUI - #43712

Merged
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/2ae12f47c443e17de25f4ec033f6078ac28b1e03
Sep 8, 2026
Merged

Enable MCP user verification in the TUI#43712
copyberry[bot] merged 1 commit into
mainfrom
copyberry/codex-internal-to-codex-oss/2ae12f47c443e17de25f4ec033f6078ac28b1e03

Conversation

@copyberry

@copyberry copyberry Bot commented Sep 8, 2026

Copy link
Copy Markdown

Enable MCP user verification in the TUI

Why

The TUI automatically canceled MCP user verification requests, preventing users from completing verification and approving them.

What changed

  • Show verification prompts for active and inactive threads, with actions to verify and approve or cancel.
  • Run approved verification through the local app-server's userVerification/verify RPC and return the proof to the original request. Cancel on failure and show a warning in the requesting thread; remote workspaces remain unsupported.
  • Deduplicate prompts, preserve foreground streaming when another thread requests verification, and surface queued prompts when returning from a side conversation.
  • Cancel verification when its thread is discarded and ignore stale results after cancellation.

Testing

Add RPC, routing, and snapshot tests covering successful verification, unsupported binaries and remote workspaces, cancellation and late proofs, prompt replay, side conversation switching, and foreground stream preservation.

## Why

The TUI automatically canceled MCP user verification requests, preventing users from completing verification and approving them.

## What changed

- Show verification prompts for active and inactive threads, with actions to verify and approve or cancel.
- Run approved verification through the local app-server's `userVerification/verify` RPC and return the proof to the original request. Cancel on failure and show a warning in the requesting thread; remote workspaces remain unsupported.
- Deduplicate prompts, preserve foreground streaming when another thread requests verification, and surface queued prompts when returning from a side conversation.
- Cancel verification when its thread is discarded and ignore stale results after cancellation.

## Testing

Add RPC, routing, and snapshot tests covering successful verification, unsupported binaries and remote workspaces, cancellation and late proofs, prompt replay, side conversation switching, and foreground stream preservation.

GitOrigin-RevId: 2ae12f47c443e17de25f4ec033f6078ac28b1e03
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@copyberry
copyberry Bot force-pushed the copyberry/codex-internal-to-codex-oss/2ae12f47c443e17de25f4ec033f6078ac28b1e03 branch from 7473f1e to c7f81af Compare September 8, 2026 05:40
@copyberry
copyberry Bot merged commit c7f81af into main Sep 8, 2026
19 of 26 checks passed
@copyberry
copyberry Bot deleted the copyberry/codex-internal-to-codex-oss/2ae12f47c443e17de25f4ec033f6078ac28b1e03 branch September 8, 2026 05:41
@github-actions github-actions Bot locked and limited conversation to collaborators Sep 8, 2026
@oiwn
oiwn deployed to issue-triage September 8, 2026 05:54 — with GitHub Actions Active
@oiwn
oiwn deployed to issue-triage September 8, 2026 05:54 — with GitHub Actions Active
@oiwn
oiwn deployed to issue-triage September 8, 2026 05:54 — with GitHub Actions Active
@oiwn
oiwn deployed to issue-triage September 8, 2026 05:55 — with GitHub Actions Active
@kendonB
kendonB deployed to issue-triage September 8, 2026 05:59 — with GitHub Actions Active
@kendonB
kendonB deployed to issue-triage September 8, 2026 05:59 — with GitHub Actions Active
@kendonB
kendonB deployed to issue-triage September 8, 2026 05:59 — with GitHub Actions Active
@kendonB
kendonB deployed to issue-triage September 8, 2026 06:00 — with GitHub Actions Active
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants