fix: preserve nested tool state during restoration#3753
Merged
Conversation
Contributor
|
Thanks for taking this forward here — the source-level approach that preserves the association at deserialization is cleaner than my after-the-fact matching, and the expanded regression coverage is great to see. No pressure at all, but if it's easy: for traceability it'd be nice to link #3749 from this PR and add a co-author trailer on the merge commit. Totally fine if not — happy either way, and thanks for the thorough follow-up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes nested agent-tool state restoration when earlier serialized function entries are skipped because their tools are disabled, removed, or no longer parseable.
Function actions are restored through a dedicated typed intermediate carrying only their normalized nested run-state data. This removes positional coupling without retaining raw serialized entries or wrapping unrelated action types. Regression coverage includes multiple skipped and pending calls, scoped independent restorations, and both approval and rejection after JSON round-trips.