fix(memory): enforce closed state in MongoDBSession - #4176
Merged
Conversation
Make owned MongoDB sessions terminal after close while preserving injected-client ownership and usability. Cover successful, failed, cancelled, and repeated cleanup paths and document the lifecycle contract. Co-authored-by: Chinmay V <203952148+chinmayv095@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes
MongoDBSessionlifecycle handling for sessions created withfrom_uri(). Closing an owned client now makes the session terminal before releasing the client, so subsequent session operations andping()fail fast withRuntimeErrorinstead of continuing against a released client.Sessions using an injected client preserve caller ownership:
session.close()remains a no-op and the session stays usable. The change also documents this lifecycle contract and covers successful, repeated, failed, and cancelled cleanup paths.