fix(run): preserve completed tool guardrail results - #4180
Merged
Conversation
Forward completed-turn tool guardrail results through runner-managed error details while preserving constructor compatibility. Co-authored-by: LHMQ878 <LHMQ878@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes missing tool input and output guardrail results in
RunErrorDetailswhen a run fails after one or more completed turns.This work follows #4127 (the original contributor is credited through a
Co-authored-bytrailer in the commit.). That PR identified the underlying observability gap and explored several failure and cancellation paths. During maintainer review, we narrowed the supported contract to results from completed turns, avoiding a broader contract for partial results from aborted, discarded, or canceled work.The implementation forwards the existing completed-turn accumulators through streaming and non-streaming error paths. It preserves the released positional constructor prefix. The currently triggering tool guardrail remains available through
exception.guardrailandexception.output.