fix: redact invalid tool argument errors - #4182
Merged
Merged
Conversation
Co-authored-by: Illia Oleksiuk <ilya.oleksiuk@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes invalid tool-argument failures leaking payload values through
ModelBehaviorErrormessages and exception chains whenDONT_LOG_TOOL_DATA=True. It applies a fixed payload-free error across direct function tools,Agent.as_tool(parameters=...), and the experimental Codex tool while preserving detailed diagnostics when tool-data logging is enabled.It supersedes PR #4012, which identified the leak and affected validation paths. This maintainer-owned replacement applies the bounded fix to current
main, preserves the original author's contribution through aCo-authored-bytrailer, and intentionally does not promise redaction from arbitrary third-party capture of Python frame locals.