fix(memory): skip conversation creation on empty add_items - #4190
Merged
Conversation
Return before resolving a conversation ID when there are no items to persist, and keep the public session_id guidance aligned with lazy initialization semantics. Co-authored-by: LeSingh1 <sshaurya914@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request incorporates and supersedes #4162. It fixes
OpenAIConversationsSession.add_items([])so an empty persistence batch no longer creates a durable OpenAI Conversation.It preserves the original fix while addressing review feedback by updating the public
session_idguidance and adding regression coverage for both uninitialized and existing-ID sessions. The original contributor is credited as a co-author.