test: make async tool and guardrail tests deterministic - #4192
Merged
Conversation
Replace scheduler-dependent timing races with explicit rendezvous while preserving sync-tool, streaming, cancellation, and background-cleanup paths. Co-authored-by: Shaurya Singh <sshaurya914@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request improves timing-sensitive tool and guardrail tests by replacing scheduler-dependent sleeps and timestamp races with explicit causal rendezvous.
It preserves the existing synchronous function-tool, streaming, cancellation, post-invoke drain, and late-cleanup execution paths. Loop-owned events are signaled safely from worker threads, test-local drain budgets keep scheduling delays from deciding failure arbitration, and blocked cleanup work is released from
finallyblocks so failed assertions cannot leave tasks behind.This incorporates the work from #4165 while preserving the original contributor's authorship through the commit's
Co-authored-bytrailer.