test: make parent cancellation tests deterministic - #4193
Merged
Conversation
Replace scheduler-sensitive cancellation assertions with state-driven synchronization and exact background callback observation. Co-authored-by: Shaurya Singh <sshaurya914@gmail.com>
4 tasks
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 90a15db97e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes two scheduler-sensitive parent-cancellation tests originally proposed in #4166, a follow-up to #4165.
Maintainer review confirmed the underlying flakiness, but the latest #4166 callback rendezvous could still complete on the wrong background task. A focused trace also confirmed that the current parent-cancellation path completes through the detached outer tool task and its wrapped
UserError.This maintainer-side takeover starts from current
main, preserves the settlement-pipeline assertion from the original contribution, and waits for the exact detached task and exception before checking that no loop-level error is reported. No runtime behavior changes.