feat(retry): allow applications to approve unsafe replays - #4319
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a855aa61d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Co-authored-by: LeSingh1 <sshaurya914@gmail.com>
seratch
force-pushed
the
feat/approve-unsafe-model-replay
branch
from
August 9, 2026 07:19
a855aa6 to
bd2964e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supersedes #4313 and resolves #4283 by allowing an application retry policy to explicitly approve a provider-marked replay-unsafe non-streamed model request.
It adds
RetryDecision.approve_unsafe_replaywithout changing existing positional parameters and exposes response-started and conversation-state facts throughRetryPolicyContext. The default remains fail-closed: ordinary retries cannot bypass replay safety, stateful requests with unknown safety stay blocked, and aborts, streamed output, and Programmatic Tool Calling side-effect boundaries remain vetoes. Policy combinators preserve explicit approval, and unrecognized provider replay classifications normalize tounknown.Documentation is intentionally deferred to a release-timed docs update because this behavior is not available in the latest published release.