fix: Chat Completions reasoning replay - #4432
Merged
Merged
Conversation
seratch
changed the title
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42dc9b6f7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
force-pushed
the
fix/chat-completions-reasoning-replay
branch
from
August 15, 2026 09:08
42dc9b6 to
9ebb5ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the Python Chat Completions adapter so that plaintext
reasoningreturned by OpenAI-compatible providers is preserved and replayed on its directly associated assistant message, matching the behavior introduced by openai/openai-agents-js#1669.It supports streaming and non-streaming responses, assistant text and tool-call messages, and persisted session history. Replay is limited to the originating model and is invalidated by unrelated or intervening reasoning items.
Existing
reasoning_contentandthinking_blocksbehavior remains unchanged. Empty and non-string values are ignored, and no public API is added.