fix(voice): decode provider PCM16 as little-endian - #4817
Open
Hughhhhcoder wants to merge 1 commit into
Open
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TTS providers return PCM16 bytes in a fixed little-endian wire format, but
StreamedAudioResultdecoded them with nativenp.int16. On big-endian hosts this swapped every non-symmetric sample before returning audio to callers. The decoder now uses explicit<i2input and normalizes to nativenp.int16, preserving the existing float32 conversion, chunk framing, odd-byte padding, and output API.Test plan
Passed:
uv run pytest tests/voice/test_pipeline.py -q(57 passed)make lintuv run mypy src/agents/voice/result.pyuv run pyright --project pyrightconfig.json src/agents/voice/result.pymake tests-serial(77 passed, 4 skipped)git diff --checkThe repository-wide verification wrapper was run.
make formatand lint passed. The repository-wide typecheck remains blocked by 9 pre-existing errors insrc/agents/function_schema.py,src/agents/sandbox/apply_patch.py,src/agents/models/openai_responses.py, andsrc/agents/extensions/memory/redis_session.py; none are in this change. The parallelmake testsrun completed with 9300 passed, 14 skipped, and 6 unrelated failures in PTY timing, MCP schema/field compatibility, and the legacy-httpx import test.Issue number
Closes #4816
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR