Fix for #967: Resolve ResponsesModel union to plain model name in URL path - #968
Open
lzandman wants to merge 1 commit into
Open
Fix for #967: Resolve ResponsesModel union to plain model name in URL path#968lzandman wants to merge 1 commit into
lzandman wants to merge 1 commit into
Conversation
…in URL path
`PrepareRequest.modelNameOrNull()` called `toString()` on whatever `model()`
returned, so a `ResponsesModel` leaked its debug form into the Azure deployment
path (`ResponsesModel{string=gpt-5.4}` instead of `gpt-5.4`). Resolve the union
through its visitor and add tests for the string, chat, and responses-only
variants.
lzandman
force-pushed
the
leon/fix-responsemodel-bug
branch
from
September 3, 2026 14:30
04f9b11 to
dddcdec
Compare
sylvesterkaczmarek
left a comment
sylvesterkaczmarek
left a comment
There was a problem hiding this comment.
Correct boundary. Resolving the ResponsesModel union before path construction avoids leaking its debug representation into model-dependent URLs, while unknown variants fail closed to null rather than inventing a path segment. The string, chat-model and responses-only tests cover the wire-name variants that matter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #967 — a regression of #371.
PrepareRequest.modelNameOrNull()reflectively callsmodel()on the request params, unwraps anOptional, and then callstoString()on whatever remains. For the Responses API,model()returnsOptional<ResponsesModel>, a union wrapper whosetoString()is a debug representation. Against a deployment-based Azure base URL that string leaked straight into the path:The gateway rejected the malformed segment with a 404.
Changes
modelNameOrNull()now unwraps theOptionalfirst, then resolves aResponsesModelthrough itsVisitorinstead oftoString(): the string variant is used as-is, and theChatModel/ResponsesOnlyModelvariants use their enumtoString(), which already yields the wire value. An unknown variant returnsnull.PrepareRequestTestcases forResponseCreateParamsbuilt with a plain string, aChatModel, and aResponsesOnlyModel.