fix: address code scanning findings#2007
Merged
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 747111806e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
HAYDEN-OAI
reviewed
Jul 17, 2026
HAYDEN-OAI
approved these changes
Jul 17, 2026
HAYDEN-OAI
left a comment
Contributor
There was a problem hiding this comment.
re-reviewed the latest changes. the earlier credential-isolation and inner error-response issues are both addressed, and i did not find any remaining blockers. looks good to me, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Six jobs inherited the repository's default
GITHUB_TOKENpermissions instead of declaring the minimum required scope. Three ecosystem-test endpoints also reused their server-side stack-trace diagnostics as public error-response bodies.Validation
./scripts/linton Node 24: Prettier, ESLint, build, TypeScript, ATTW, publint, and JSR dry-run all passed./scripts/teston Node 24: 117 suites and 1,193 tests passed; one test intentionally skippedpnpm tsn ecosystem-tests/cli.ts cloudflare-worker vercel-edge --jobs=1 --verbose: both packages passed against the locally builtopenai-6.48.0tarballactionlinton both changed workflows: passed