[SDK-198] Migrate ESLint and Prettier to Oxlint and Oxfmt by HAYDEN-OAI · Pull Request #2044 · openai/openai-node

HAYDEN-OAI · 2026-08-01T00:48:36Z

I understand that this repository is auto-generated and my pull request may not be merged

Changes being requested

Migrate the existing ESLint/Prettier toolchain to standalone Oxlint and Oxfmt.

Pin oxlint@1.75.0 and oxfmt@0.60.0, and remove the root ESLint, TypeScript-ESLint, and Prettier dependencies.
Preserve the existing formatting options, exclusions, restricted self-import rule, fixture exceptions, and historical breaking-change compatibility.
Add a small dependency-free Oxlint plugin to preserve the current unused-import-only behavior without introducing broad unused-variable errors.
Update the existing lint/format/fast-format scripts, contributor documentation, and VS Code development-container integration.
Apply the one-time mechanical formatting migration required because Oxfmt does not support Prettier's experimentalTernaries option.

Additional context & links

Linear: https://linear.app/openai/issue/SDK-198/migrate-eslint-and-prettier-to-oxlint-and-oxfmt

Validation

pnpm lint
pnpm test:unit — 61 test files and 1,453 tests passing
20 focused Oxlint import-rule/autofix cases passing
pnpm format and selective/empty scripts/fast-format behavior verified

Tooling performance

Median wall-clock time for the exact repository checks:

Check	ESLint / Prettier	Oxlint / Oxfmt	Improvement
Formatting	Prettier 3.1.1: 6.44s	Oxfmt 0.60.0: 0.87s	7.4× faster (86% less time)
Linting	ESLint 9.39.4: 4.22s	Oxlint 1.75.0: 0.89s	4.7× faster (79% less time)
Combined	10.72s	1.79s	6.0× faster (83% less time)

Measured on Linux x64 with Node 26.5.0 and 32 available logical CPUs. Each result is the median of seven interleaved runs after two warmup runs, using isolated tracked-file snapshots of base aeab0549 and PR head b014a1f; repository ignore rules were preserved and the local untracked coverage/ directory was excluded from both snapshots. No persistent formatter or linter caches were enabled.

# Before
prettier --check .
eslint .

# After
oxfmt --check .
oxlint .

Combined timings were measured by running the formatter and linter sequentially; unchanged build, TypeScript, and package-validation stages were excluded.

openai-sdks · 2026-08-03T16:24:16Z

OkTest Summary

✅ 237/237 SDK tests passed in 10.558s for Node SDK PR #2044.

Test results — 42 files

Test	Result	Time
`tests/chat-completions-complex-body.test.ts`	✅ Passed	188ms
`tests/chat-completions-create.test.ts`	✅ Passed	274ms
`tests/chat-completions-stream.test.ts`	✅ Passed	138ms
`tests/files-content-binary.test.ts`	✅ Passed	163ms
`tests/files-create-multipart.test.ts`	✅ Passed	141ms
`tests/files-list-pagination.test.ts`	✅ Passed	147ms
`tests/initialize-config.test.ts`	✅ Passed	158ms
`tests/instance-isolation.test.ts`	✅ Passed	103ms
`tests/models-list.test.ts`	✅ Passed	133ms
`tests/responses-background-lifecycle.test.ts`	✅ Passed	221ms
`tests/responses-body-method-errors.test.ts`	✅ Passed	331ms
`tests/responses-cancel-timeout.test.ts`	✅ Passed	224ms
`tests/responses-cancel.test.ts`	✅ Passed	269ms
`tests/responses-compact-retries.test.ts`	✅ Passed	254ms
`tests/responses-compact.test.ts`	✅ Passed	245ms
`tests/responses-create-advanced-stream.test.ts`	✅ Passed	115ms
`tests/responses-create-advanced.test.ts`	✅ Passed	260ms
`tests/responses-create-disconnect.test.ts`	✅ Passed	1.129s
`tests/responses-create-errors.test.ts`	✅ Passed	181ms
`tests/responses-create-malformed-api-responses.test.ts`	✅ Passed	129ms
`tests/responses-create-retries.test.ts`	✅ Passed	270ms
`tests/responses-create-stream-failures.test.ts`	✅ Passed	222ms
`tests/responses-create-stream-timeout.test.ts`	✅ Passed	2.157s
`tests/responses-create-stream-wire.test.ts`	✅ Passed	2.616s
`tests/responses-create-stream.test.ts`	✅ Passed	93ms
`tests/responses-create-terminal-states.test.ts`	✅ Passed	240ms
`tests/responses-create-timeout.test.ts`	✅ Passed	216ms
`tests/responses-create.test.ts`	✅ Passed	186ms
`tests/responses-delete.test.ts`	✅ Passed	199ms
`tests/responses-input-items-errors.test.ts`	✅ Passed	177ms
`tests/responses-input-items-list.test.ts`	✅ Passed	198ms
`tests/responses-input-items-options.test.ts`	✅ Passed	106ms
`tests/responses-input-tokens-count-timeout.test.ts`	✅ Passed	230ms
`tests/responses-input-tokens-count.test.ts`	✅ Passed	270ms
`tests/responses-malformed-inputs.test.ts`	✅ Passed	2.292s
`tests/responses-not-found-errors.test.ts`	✅ Passed	257ms
`tests/responses-parse.test.ts`	✅ Passed	199ms
`tests/responses-retrieve-retries.test.ts`	✅ Passed	236ms
`tests/responses-retrieve.test.ts`	✅ Passed	270ms
`tests/responses-stored-method-errors.test.ts`	✅ Passed	559ms
`tests/retry-behavior.test.ts`	✅ Passed	3.129s
`tests/sdk-error-shape.test.ts`	✅ Passed	259ms

View OkTest run #30865318567

_{SDK merge (9fc00ab3e7a3) · head (a83c977276e1) · base (481b325a0731) · OkTest (91635c6a2723)}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b014a1f580

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jbeckwith-oai

Comprehensive review of the exact current head. I found five reproducible correctness/parity regressions in the new lint/format path. CI and the existing suites are green, but they do not exercise these fixer and incremental-workflow cases; please add committed regression coverage with the fixes.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 22a138b0ab

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 17152d6d2a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 71a534c94e

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5895555699

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fbc8ff7713

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ee837bb39c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

[SDK-198] Migrate ESLint and Prettier to Oxlint and Oxfmt

a71f8c1

HAYDEN-OAI temporarily deployed to ci August 1, 2026 00:48 — with GitHub Actions Inactive

github-code-quality Bot found potential problems Aug 1, 2026

View reviewed changes

Comment thread tests/uploads.test.ts Fixed

test: split upload assignability void statements

b014a1f

HAYDEN-OAI temporarily deployed to ci August 1, 2026 01:07 — with GitHub Actions Inactive

HAYDEN-OAI marked this pull request as ready for review August 3, 2026 16:23

HAYDEN-OAI requested a review from a team as a code owner August 3, 2026 16:23

HAYDEN-OAI temporarily deployed to ci August 3, 2026 16:23 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/fast-format Outdated

chore: explicitly write incremental formatting changes

56223b9

HAYDEN-OAI temporarily deployed to ci August 3, 2026 16:37 — with GitHub Actions Inactive

jbeckwith-oai requested changes Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs Outdated

Comment thread scripts/oxlint-plugin.cjs

Comment thread scripts/oxlint-plugin.cjs Outdated

Comment thread scripts/fast-format Outdated

Comment thread scripts/fast-format Outdated

[SDK-198] Fix Oxlint migration regressions

ae713c2

HAYDEN-OAI temporarily deployed to ci August 3, 2026 18:43 — with GitHub Actions Inactive

[SDK-198] Remove sibling namespace exemption

b43f59d

HAYDEN-OAI temporarily deployed to ci August 3, 2026 18:49 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs Outdated

Comment thread scripts/oxlint-plugin.cjs

Comment thread scripts/oxlint-plugin.cjs

[lint] resolve scoped and nested JSDoc import references

17152d6

HAYDEN-OAI temporarily deployed to ci August 3, 2026 22:18 — with GitHub Actions Inactive

HAYDEN-OAI temporarily deployed to ci August 3, 2026 22:19 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs Outdated

[lint] scope sequential JSDoc generic parameter references

71a534c

HAYDEN-OAI temporarily deployed to ci August 3, 2026 22:39 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs Outdated

Comment thread scripts/oxlint-plugin.cjs

fix: respect nested JSDoc type binder scopes

5895555

HAYDEN-OAI temporarily deployed to ci August 3, 2026 22:59 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs

Comment thread scripts/oxlint-plugin.cjs

fix: handle JSDoc parameter scopes and import aliases

fbc8ff7

HAYDEN-OAI temporarily deployed to ci August 3, 2026 23:29 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs

Comment thread scripts/lint

Comment thread scripts/oxlint-plugin.cjs

fix: resolve JSDoc hosts and declaration parameter scopes

ee837bb

HAYDEN-OAI temporarily deployed to ci August 3, 2026 23:52 — with GitHub Actions Inactive

chatgpt-codex-connector Bot reviewed Aug 3, 2026

View reviewed changes

Comment thread scripts/oxlint-plugin.cjs Outdated

Comment thread scripts/oxlint-plugin.cjs Outdated

fix: respect JSDoc script modes and type namespaces

a83c977

Uh oh!

Conversation

HAYDEN-OAI commented Aug 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes being requested

Additional context & links

Validation

Tooling performance

Uh oh!

Uh oh!

openai-sdks Bot commented Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OkTest Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

jbeckwith-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

HAYDEN-OAI commented Aug 1, 2026 •

edited

Loading

openai-sdks Bot commented Aug 3, 2026 •

edited

Loading