ci: compare Agents SDK type errors against PR base - #3603
Open
jbeckwith-oai wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d199f5929
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n\n- run the Agents SDK type check against the PR base and proposed SDK in isolated checkouts\n- fail when the proposed SDK introduces a new mypy diagnostic\n- keep unexpected checker failures fatal instead of treating them as existing incompatibilities\n\nThis fixes the false failure blocking #3601 without hiding future regressions. The current base and the unrelated release PR #3600 both reproduce the same eight HTTPX/HTTPX2 diagnostics.\n\n## Validation\n\n- \n- parsed the workflow as YAML\n- ran the full base/head installation and type-check comparison locally; both sides reproduced the same eight diagnostics and the comparison passed\n- thermo-nuclear quality review: no blockers