Skip to content

ci: compare Agents SDK type errors against PR base - #3603

Open
jbeckwith-oai wants to merge 2 commits into
mainfrom
codex/agents-sdk-regression-baseline
Open

ci: compare Agents SDK type errors against PR base#3603
jbeckwith-oai wants to merge 2 commits into
mainfrom
codex/agents-sdk-regression-baseline

Conversation

@jbeckwith-oai

Copy link
Copy Markdown
Contributor

Summary\n\n- run the Agents SDK type check against the PR base and proposed SDK in isolated checkouts\n- fail when the proposed SDK introduces a new mypy diagnostic\n- keep unexpected checker failures fatal instead of treating them as existing incompatibilities\n\nThis fixes the false failure blocking #3601 without hiding future regressions. The current base and the unrelated release PR #3600 both reproduce the same eight HTTPX/HTTPX2 diagnostics.\n\n## Validation\n\n- \n- parsed the workflow as YAML\n- ran the full base/head installation and type-check comparison locally; both sides reproduced the same eight diagnostics and the comparison passed\n- thermo-nuclear quality review: no blockers

@jbeckwith-oai
jbeckwith-oai requested a review from a team as a code owner August 12, 2026 18:41
@openai-sdks

openai-sdks Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

OkTest Summary

237/237 SDK tests passed in 11.549s for Python SDK PR #3603.

Test results — 42 files
Test Result Time
tests/chat-completions-complex-body.test.ts ✅ Passed 169ms
tests/chat-completions-create.test.ts ✅ Passed 247ms
tests/chat-completions-stream.test.ts ✅ Passed 133ms
tests/files-content-binary.test.ts ✅ Passed 222ms
tests/files-create-multipart.test.ts ✅ Passed 266ms
tests/files-list-pagination.test.ts ✅ Passed 155ms
tests/initialize-config.test.ts ✅ Passed 207ms
tests/instance-isolation.test.ts ✅ Passed 198ms
tests/models-list.test.ts ✅ Passed 154ms
tests/responses-background-lifecycle.test.ts ✅ Passed 220ms
tests/responses-body-method-errors.test.ts ✅ Passed 319ms
tests/responses-cancel-timeout.test.ts ✅ Passed 193ms
tests/responses-cancel.test.ts ✅ Passed 237ms
tests/responses-compact-retries.test.ts ✅ Passed 297ms
tests/responses-compact.test.ts ✅ Passed 230ms
tests/responses-create-advanced-stream.test.ts ✅ Passed 133ms
tests/responses-create-advanced.test.ts ✅ Passed 312ms
tests/responses-create-disconnect.test.ts ✅ Passed 1.411s
tests/responses-create-errors.test.ts ✅ Passed 204ms
tests/responses-create-malformed-api-responses.test.ts ✅ Passed 236ms
tests/responses-create-retries.test.ts ✅ Passed 244ms
tests/responses-create-stream-failures.test.ts ✅ Passed 139ms
tests/responses-create-stream-timeout.test.ts ✅ Passed 238ms
tests/responses-create-stream-wire.test.ts ✅ Passed 3.807s
tests/responses-create-stream.test.ts ✅ Passed 312ms
tests/responses-create-terminal-states.test.ts ✅ Passed 234ms
tests/responses-create-timeout.test.ts ✅ Passed 225ms
tests/responses-create.test.ts ✅ Passed 346ms
tests/responses-delete.test.ts ✅ Passed 228ms
tests/responses-input-items-errors.test.ts ✅ Passed 333ms
tests/responses-input-items-list.test.ts ✅ Passed 312ms
tests/responses-input-items-options.test.ts ✅ Passed 306ms
tests/responses-input-tokens-count-timeout.test.ts ✅ Passed 249ms
tests/responses-input-tokens-count.test.ts ✅ Passed 225ms
tests/responses-malformed-inputs.test.ts ✅ Passed 2.958s
tests/responses-not-found-errors.test.ts ✅ Passed 280ms
tests/responses-parse.test.ts ✅ Passed 384ms
tests/responses-retrieve-retries.test.ts ✅ Passed 347ms
tests/responses-retrieve.test.ts ✅ Passed 325ms
tests/responses-stored-method-errors.test.ts ✅ Passed 594ms
tests/retry-behavior.test.ts ✅ Passed 3.2s
tests/sdk-error-shape.test.ts ✅ Passed 278ms

View OkTest run #31629559572

SDK merge (18519f3776a8) · head (e54cde7d516f) · base (a1eeab58db02) · OkTest (a845fa206fa4)

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7d199f5929

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread .github/workflows/detect-breaking-changes.yml Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant