fix: tighten JSON, JSONL, and SSE content type matching - #277
Merged
jbeckwith-oai merged 2 commits intoAug 10, 2026
Conversation
fallintoplace
marked this pull request as ready for review
May 19, 2026 17:41
fallintoplace
force-pushed
the
fix/jsonl-content-type-regex
branch
from
July 16, 2026 23:29
d89ace1 to
4f5db1e
Compare
jbeckwith-oai
force-pushed
the
fix/jsonl-content-type-regex
branch
from
August 10, 2026 21:19
4f5db1e to
5a7c815
Compare
jbeckwith-oai
force-pushed
the
fix/jsonl-content-type-regex
branch
from
August 10, 2026 21:34
5a7c815 to
bf02d23
Compare
jbeckwith-oai
approved these changes
Aug 10, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
application/jsonLx-ndjson,x-ldjson,jsonl, andx-jsonlmedia types with optional parameters and horizontal whitespaceWhy
encode_contentanddecode_contentselect JSON, JSONL, and SSE behavior by content type. The previous JSONL regex matched unrelated values, while the JSON matcher could claim mixed-case JSONL before JSONL dispatch. Prefix-only matching also accepted invalid suffixes such asapplication/json-seqandtext/event-streaming.These cases could parse the wrong format, raise parser errors, or return the wrong decoded shape.
Fixes #276.
Test plan
mise exec ruby@4.0.6 -- ./scripts/testmise exec ruby@4.0.6 -- bundle exec rake lintmise exec ruby@4.0.6 -- bundle exec rake build:gem