Fix Burrito release tag verification#101
Merged
Merged
Conversation
Summary: - add checkout to the Burrito release job before invoking gh release Rationale: - gh release create --verify-tag requires a Git checkout - the v0.0.1 tag run built and smoke-tested every artifact but failed while creating the GitHub Release because the job had no .git directory Tests: - actionlint .github/workflows/burrito-release.yml - yq eval .github/workflows/burrito-release.yml - git diff --check Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The v0.0.1 tag run built and smoke-tested every artifact, but release creation failed because the job had no Git checkout.
TL;DR
Check out Git before verifying release tags.
Summary
gh release create --verify-tag.Alternatives
--verify-tagwould hide tag mistakes instead of fixing the missing Git context.Test Plan
yq eval .github/workflows/burrito-release.ymlactionlint .github/workflows/burrito-release.ymlgit diff --check