Retry failed workspace setup and anchor local roots#111
Merged
Conversation
Summary: - Remove newly created partial workspaces when after_create fails. - Resolve local relative workspace roots from the selected workflow file. - Keep remote workspace roots raw while sharing one local root helper. - Add regressions for bootstrap retry and explicit workflow paths. Rationale: - A failed bootstrap should not turn into a reusable incomplete workspace. - Launching a workflow from another directory must not silently move local workspaces under the launcher cwd. Tests: - mise exec -- mix test test/symphony_elixir/workspace_and_config_test.exs:60 - mise exec -- mix test test/symphony_elixir/workspace_and_config_test.exs:244 - mise exec -- mix test test/symphony_elixir/workspace_and_config_test.exs - mise exec -- mix test test/symphony_elixir/app_server_test.exs - HEX_HOME=/private/tmp/symphony-hex mise exec -- make -C elixir all Co-authored-by: Codex <codex@openai.com>
…etup-paths # Conflicts: # elixir/lib/symphony_elixir/workspace.ex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Failed new-workspace bootstrap was skipped on retry, and relative local roots followed launcher cwd instead of the selected workflow file.
TL;DR
Retry failed bootstrap cleanly and anchor local roots to WORKFLOW.md.
Summary
after_createfails.Alternatives
Test Plan
make -C elixir allmise exec -- mix test test/symphony_elixir/workspace_and_config_test.exs:60mise exec -- mix test test/symphony_elixir/workspace_and_config_test.exs:244