Skip to content

[web] Add Symphony favicon#90

Merged
sharmila-oai merged 2 commits into
mainfrom
dev/sharmila/eacc-1954-symphony-favicon
Jun 9, 2026
Merged

[web] Add Symphony favicon#90
sharmila-oai merged 2 commits into
mainfrom
dev/sharmila/eacc-1954-symphony-favicon

Conversation

@sharmila-oai

Copy link
Copy Markdown
Contributor

Context

Symphony Observability currently uses the browser's generic fallback icon, which makes its control-plane tabs hard to identify.

TL;DR

Add a custom, cache-busted favicon to the Symphony Observability dashboard.

Summary

  • Add a generated 128x128 transparent PNG mark for Symphony.
  • Serve the favicon through the existing embedded static-asset controller.
  • Add a content digest to the favicon URL to avoid stale browser caches.
  • Verify the favicon markup, route response, content type, and binary body.

Alternatives

  • Keep the generic browser icon. This leaves Symphony tabs difficult to distinguish.
  • Embed a data URI in the layout. A normal asset route is easier to cache, test, and replace.

Test Plan

  • make -C elixir all
  • mix test test/symphony_elixir/extensions_test.exs
  • Browser preview at http://127.0.0.1:4022/

@sharmila-oai

Copy link
Copy Markdown
Contributor Author

@codex review

Sent by Codex

@sharmila-oai

Copy link
Copy Markdown
Contributor Author

Replaced the original abstract mark with the selected top-down orchestra seating map: discrete section blocks around a conductor, podium, and baton. The asset was tightly cropped, converted to transparent PNG, and verified at 128px and 32px.

@codex review

Sent by Codex

@sharmila-oai sharmila-oai added the symphony Track Symphony work for codebase label Jun 9, 2026
@sharmila-oai
sharmila-oai marked this pull request as ready for review June 9, 2026 23:16
@sharmila-oai

Copy link
Copy Markdown
Contributor Author

All required checks are green and the final orchestra seating favicon revision is ready.

@codex review

Sent by Codex

@sharmila-oai

Copy link
Copy Markdown
Contributor Author

Current-commit review completed for ead0ad3b1ae602ff1497cdd3c3d300caf163ed9a: no actionable findings. The diff follows the existing embedded static-asset pattern, tests the markup and binary response, and contains no private URLs, internal project names, credentials, or local paths. Local make all passed with 241 tests and 100% coverage, and all GitHub checks are green. The automated Codex connector did not respond to three review requests.

Sent by Codex

@sharmila-oai
sharmila-oai merged commit 4cbe3a9 into main Jun 9, 2026
3 checks passed
@sharmila-oai
sharmila-oai deleted the dev/sharmila/eacc-1954-symphony-favicon branch June 9, 2026 23:25
SynchronDEV added a commit to SynchronDEV/symphony that referenced this pull request Jun 11, 2026
Summary:
- Add persistent per-issue ledger counters, terminal metrics, and status
  API projections for blocked reasons, retries, tokens, stall events, and
  declined elicitations.
- Add structured Linear rate-limit handling, required-label routing,
  delta polling, batched issue refreshes, retry jitter, and FIFO slot
  draining.
- Preserve more Codex context with same-thread timeout/stall recovery,
  previous-attempt prompt injection, in-place tracker-refresh pauses, and
  per-state prompt templates.
- Enforce token, dispatch, and rework caps with Linear comments and stop
  labels, and improve workspace mirror/retention cleanup.
- Port upstream dashboard issue links, favicon/static asset versioning, and
  update FORK/WORKFLOW/AGENTS documentation.

Rationale:
- Production runs were losing useful context and burning tokens on rate
  limits, stale retries, and zombie re-dispatch loops.
- The ledger and cap checks make expensive failure modes durable across
  restarts, while same-thread recovery and previous-attempt context reduce
  re-exploration cost.
- Manually porting upstream openai#88-openai#90 keeps behavior current before the
  follow-up history reconciliation merge.

Tests:
- /opt/homebrew/bin/mise exec -- mix format
- /opt/homebrew/bin/mise exec -- mix specs.check
- /opt/homebrew/bin/mise exec -- mix test

Co-authored-by: Codex <codex@openai.com>
tennisonchan added a commit to truewind-ai/symphony that referenced this pull request Jul 1, 2026
Merge upstream openai/symphony main through favicon openai#90 before applying Truewind-specific team-scoped polling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

symphony Track Symphony work for codebase

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant