Preserve last good config on typed-invalid reloads#96
Merged
Conversation
Summary: - Cache parsed settings with workflow state and reject typed-invalid reloads. - Keep operational getters on last known good while preflight surfaces reload errors. - Add regression coverage for valid and typed-invalid reload transitions. Rationale: - YAML-valid invalid values previously replaced the cache and made settings! raise. - Reloading config and prompt atomically prevents scheduler crashes without broadening semantic preflight. Tests: - mix test test/symphony_elixir/extensions_test.exs:104 - mix test test/symphony_elixir/core_test.exs - mix test test/symphony_elixir/workspace_and_config_test.exs - mix test --cover --seed 659305 - make all Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
A YAML-valid, typed-invalid reload replaced cached config and prompt, then made
Config.settings!raise.TL;DR
Keep the last good typed workflow when a reload cannot be parsed.
Summary
Alternatives
settings!.Test Plan
mix test test/symphony_elixir/extensions_test.exs:104mix test --cover --seed 659305make -C elixir all