Validate workflow before scheduling#98
Merged
Merged
Conversation
Summary: - Keep only semantically valid workflow settings in WorkflowStore. - Reject blank Linear settings and whitespace-only Codex commands. - Fail orchestrator startup cleanly when no valid settings are available. - Add regressions for cold startup, invalid reloads, and OTP restarts. Rationale: - The scheduler must not start with config it cannot dispatch with. - Invalid reloads must keep using last-known-good settings instead of taking down a restarted runtime. Tests: - mise exec -- make all - mise exec -- mix test --seed 567691 --max-failures 1 Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Symphony could start scheduling with semantically invalid workflow
settings, while blank required values also passed validation.
TL;DR
Validate workflow settings before they become effective or start scheduling.
Summary
Alternatives
could break ordinary OTP restarts.
appeared healthy with invalid settings.
Test Plan
cd elixir && mise exec -- make allcd elixir && mise exec -- mix test --seed 567691 --max-failures 1