Modernize redux: workflowSlice - #247
Merged
gregorydlogan merged 8 commits intoFeb 22, 2024
Merged
Conversation
Turns out even more of the parameters for the addNotification function in the notificationThunks are perfectly optional.
Fixes a "can't access lexical declaration 'X' before initialization" error, by resolving a kind of circular dependency.
Switching to redux toolkit for getting workflows for the start workflow dropdowns. Does not work yet. - Workflow Configuration cannot be edited. - Console errors.
Apparently we don't need to pass the key all the way down, React just handles that for us and complains if it we try to do it ourselves.
Fixes an issue where the workflow configuration could not be changed when trying to start a new task. Also fixes some minor display issues.
Replaces spaces with tabs
Arnei
marked this pull request as ready for review
January 3, 2024 11:16
Also removed an instance where response data was typed as state data.
owi92
approved these changes
Feb 15, 2024
owi92
left a comment
owi92
left a comment
Contributor
There was a problem hiding this comment.
Workflow tab and dropdown appear to be working. (See #242 (review) for more info on these approvals)
Contributor
|
This pull request has conflicts ☹ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with #213.
Switching to redux toolkit for getting workflows for the start workflow dropdowns.
Draft because it's not working yet. Know issues:
Workflow Configuration cannot be edited.Console errors.