Fix license strings not being translated in metadata dropdown - #634
Merged
ziegenberg merged 1 commit intoJun 5, 2024
Merged
Conversation
For example, "ALLRIGHTS" would be shown instead of "All rights reservered". This is fixed now, by hopefully properly parsing listproviders that put JSON arrays as their values instead of strings.
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/634/2024-06-05_12-01-34/ . |
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
ziegenberg
self-requested a review
June 5, 2024 12:50
Member
|
Tested this with custom labels and that works as well: list.name=LICENSES
…
CC0={"label":"EVENTS.LICENSE.CC0", "order":8, "selectable": true}
LK={"label":"Lars' license", "order":8, "selectable": true}
LK2=Lars' second license |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example, "ALLRIGHTS" would be shown instead of "All rights reservered". This is fixed now, by hopefully properly parsing listproviders that put JSON arrays as their values instead of strings.
Fixes #559.