Skip to content

Fix license strings not being translated in metadata dropdown - #634

Merged
ziegenberg merged 1 commit into
opencast:mainfrom
Arnei:translate-license-in-metadata-dropdown
Jun 5, 2024
Merged

Fix license strings not being translated in metadata dropdown#634
ziegenberg merged 1 commit into
opencast:mainfrom
Arnei:translate-license-in-metadata-dropdown

Conversation

@Arnei

@Arnei Arnei commented Jun 5, 2024

Copy link
Copy Markdown
Member

For example, "ALLRIGHTS" would be shown instead of "All rights reservered". This is fixed now, by hopefully properly parsing listproviders that put JSON arrays as their values instead of strings.

Fixes #559.

For example, "ALLRIGHTS" would be shown instead of "All rights
reservered". This is fixed now, by hopefully properly parsing
listproviders that put JSON arrays as their values instead of
strings.
@Arnei Arnei added type:bug Something isn't working bugbash labels Jun 5, 2024
@github-actions

github-actions Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

This pull request is deployed at test.admin-interface.opencast.org/634/2024-06-05_12-01-34/ .
It might take a few minutes for it to become available.

@github-actions

github-actions Bot commented Jun 5, 2024

Copy link
Copy Markdown
Contributor

Use docker or podman to test this pull request locally.

Run test server using develop.opencast.org as backend:

podman run --rm -it -p 127.0.0.1:3000:3000 ghcr.io/opencast/opencast-admin-interface:pr-634

Specify a different backend like stable.opencast.org:

podman run --rm -it -p 127.0.0.1:3000:3000 -e PROXY_TARGET=https://stable.opencast.org ghcr.io/opencast/opencast-admin-interface:pr-634

It may take a few seconds for the interface to spin up.
It will then be available at http://127.0.0.1:3000.
For more options you can pass on to the proxy, take a look at the README.md.

@ziegenberg
ziegenberg self-requested a review June 5, 2024 12:50

@ziegenberg ziegenberg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It Works!

@ziegenberg
ziegenberg merged commit e86f4a2 into opencast:main Jun 5, 2024
@lkiesow

lkiesow commented Jun 5, 2024

Copy link
Copy Markdown
Member

Tested this with custom labels and that works as well:

list.name=LICENSES
…
CC0={"label":"EVENTS.LICENSE.CC0", "order":8, "selectable": true}
LK={"label":"Lars' license", "order":8, "selectable": true}
LK2=Lars' second license

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License field content displays inconsistently in editor vs metadata

3 participants