Correctly display “00” in event details scheduling - #682
Merged
Conversation
Since `00` is a `falsy` value, it wasn't used as value in the scheduling tab input fields. This patch fixes the problem by only checking for `null` and `undefined` instead. This fixes opencast#611
Contributor
|
This pull request is deployed at test.admin-interface.opencast.org/682/2024-06-08_07-39-10/ . |
Contributor
|
Use Run test server using develop.opencast.org as backend: Specify a different backend like stable.opencast.org: It may take a few seconds for the interface to spin up. |
reiferschris
approved these changes
Jun 10, 2024
reiferschris
left a comment
reiferschris
left a comment
Contributor
There was a problem hiding this comment.
I can confirm that this works as it should :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
00is afalsyvalue, it wasn't used as value in the scheduling tab input fields. This patch fixes the problem by only checking fornullandundefinedinstead.This fixes #611