build(deps): bump modernc.org/sqlite from 1.54.0 to 1.55.0 - #132
build(deps): bump modernc.org/sqlite from 1.54.0 to 1.55.0#132dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [modernc.org/sqlite](https://gitlab.com/cznic/sqlite) from 1.54.0 to 1.55.0. - [Changelog](https://gitlab.com/cznic/sqlite/blob/master/CHANGELOG.md) - [Commits](https://gitlab.com/cznic/sqlite/compare/v1.54.0...v1.55.0) --- updated-dependencies: - dependency-name: modernc.org/sqlite dependency-version: 1.55.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
|
Codex review: needs changes before merge. Reviewed August 1, 2026, 6:57 PM ET / 22:57 UTC. ClawSweeper reviewWhat this changesThe PR updates Gitcrawl’s direct production SQLite driver from Merge readiness⛔ Blocked until real behavior proof is added - 6 items remain Keep this PR open: the SQLite upgrade changes the meaning and validation of URI query parameters, but Gitcrawl still accepts configured Priority: P2 Review scores
Verification
How this fits togetherGitcrawl loads its database path from configuration or flowchart LR
A[Config file or environment] --> B[Runtime database path]
B --> C[Portable-store redirect check]
C --> D[SQLite store open]
D --> E[Schema migration and queries]
E --> F[CLI archive commands]
Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Copy recommended automerge instructionTechnical reviewBest possible solution: Preserve Gitcrawl’s documented filesystem-path-only contract by rejecting SQLite URI and in-memory values from every configuration and environment source before opening the database, then merge the version bump with focused upgrade regressions. Do we have a high-confidence way to reproduce the issue? Yes, source establishes a high-confidence path: set Is this the best way to solve the issue? No; a version-only pin is not the safest solution while runtime configuration bypasses the existing filesystem-path validation. Applying that existing contract to all configuration sources is the narrowest maintainable repair. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against dcdf94703540. LabelsLabel justifications:
EvidenceAcceptance criteria:
What I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (14 earlier review cycles; latest 8 shown)
|
|
Superseded by #136, which reproduces the configured SQLite URI gap, applies the filesystem-only path contract to top-level config, config-backed environment values, and process environment overrides, adds regression coverage, and updates SQLite to v1.55.0 with the current dependency closure. Proof on #136 includes the full Go suite, build, lint/vulnerability/dead-code gates, and source-blind CLI runs: ordinary filesystem paths succeed, while |
|
Superseded by the verified fix and dependency refresh landed in #136. The reproduction and proof are recorded in #132 (comment). |
|
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps modernc.org/sqlite from 1.54.0 to 1.55.0.
Changelog
Sourced from modernc.org/sqlite's changelog.
... (truncated)
Commits
cfb9734CHANGELOG.md: document the DSN validation-order change0895392sqlite: validate all DSN parameters before applying any of them63a57e4sqlite: select DSN shorthand aliases by presence, matching mattn (!134 follow...d7210fcCHANGELOG.md: correct the !134 DSN shorthand-key entryb31f521Merge branch 'dsn-compat-keys' into 'master'266b979sqlite: validate mattn-compat DSN keys and fix auto_vacuum apply order9784122sqlite: document mattn-compat DSN pragma keys and test them together5831f4bSupport more underscore keys in DSNDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)