build(deps): refresh dependency closure - #136
Conversation
|
Codex review: needs real behavior proof before merge. Reviewed August 1, 2026, 10:56 PM ET / August 2, 2026, 02:56 UTC. ClawSweeper reviewWhat this changesThe branch updates CrawlKit, SQLite and related Go dependencies, bumps the TruffleHog workflow action, and rejects SQLite URI or in-memory values from configured and environment-supplied database paths. Merge readiness⛔ Blocked until real behavior proof is added - 6 items remain Keep this PR open: the SQLite upgrade changes an accepted runtime configuration into a startup error for existing URI-based setups, so maintainers need to confirm the upgrade policy and the contributor needs attachable real CLI proof. The repository’s deep pre-release history was only partly available because missing promisor objects could not be fetched during this read-only review, but the current source, exact PR diff, tests, and release state were inspected. Priority: P1 Review scores
Verification
How this fits togetherGitcrawl resolves its local archive database location from saved configuration and runtime environment variables before commands such as status, doctor, and the TUI access SQLite. The patch enforces the documented filesystem-path boundary at that configuration layer while upgrading the SQLite driver that now gives URI query parameters additional meaning. flowchart LR
A[CLI flags and config file] --> B[Runtime environment overrides]
B --> C[Database path normalization]
C --> D[Filesystem-path decision]
D --> E[SQLite archive]
E --> F[Status, doctor, and TUI commands]
Decision needed
Why: Current runtime behavior accepts these values while the proposed driver upgrade makes URI query parameters materially more consequential; choosing an immediate failure versus a compatibility period is an upgrade-policy decision, not a mechanical code repair. Before merge
Findings
Agent review detailsSecurityNone. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the filesystem-only policy if maintainers intend to protect archives from SQLite 1.55 URI semantics, but provide an explicit migration message and proof for an existing URI-based installation before merging; leave release notes to the release process. Do we have a high-confidence way to reproduce the issue? Yes, at source level: on the PR head, set Is this the best way to solve the issue? Unclear. Rejecting URI paths aligns with the existing documented and Full review comments:
Overall correctness: patch is incorrect AGENTS.md: not found in the target repository. Codex review notes: model internal, reasoning high; reviewed against dcdf94703540. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rank-up movesOptional improvements that raise the rating; they are not merge blockers.
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
Summary
This supersedes #132, #133, and #135. It intentionally does not include #134:
actions/stale@v11is a write-capable major automation update and still needs controlled issue/PR behavior proof before landing.Proof
GOWORK=off go test ./... -count=1make buildmake test-releasemake lint(go vet, govulncheck, deadcode)make tidy-checkwith the intended manifests stagedactionlint[env]SQLite URI variants returned exit 1 with the filesystem-path contract error and created no database/sidecar files/configuration/