feat(web-pkg): optional unload warning for loading tasks - #3135
Merged
Conversation
addTask gains a warnBeforeUnload option (default true). Tasks that opt out never arm the browser's beforeunload confirmation, and the listener now follows warning tasks instead of any tasks, so an opted-out task cannot detach it while a warning task is still running.
dschmidt
marked this pull request as ready for review
August 15, 2026 14:54
JammingBen
approved these changes
Aug 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LoadingService.addTaskgains awarnBeforeUnloadoption (defaulttrue, no behavior change for existing callers). Tasks that opt out never arm the browser's beforeunload confirmation dialog; the listener follows warning tasks instead of any tasks, so an opted-out task cannot detach it while a warning task is still running.Motivation: long-running tasks that only drive the global progress bar (e.g. a photo slideshow) are not unsaved operations and should not make the browser ask "changes you made may not be saved" on reload.