Add option to disable new session keys#874
Merged
cyphar merged 1 commit intoopencontainers:masterfrom Jun 12, 2016
Merged
Conversation
This adds an `--no-new-keyring` flag to run and create so that a new session keyring is not created for the container and the calling processes keyring is inherited. Fixes opencontainers#818 Signed-off-by: Michael Crosby <crosbymichael@gmail.com>
Contributor
|
Looks good but do you mind changing the docs as well? Based on #878 I just committed. |
Member
Author
|
@hqhq wouldn't it be better to just wait and update the man pages from your PR after this is merged because you have the new |
Contributor
|
@crosbymichael I'm ok with eigher. |
Contributor
|
LGTM |
1 similar comment
Member
|
LGTM |
stefanberger
pushed a commit
to stefanberger/runc
that referenced
this pull request
Sep 8, 2017
config.go: tiny tfix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an
--no-new-keyringflag to run and create so that a newsession keyring is not created for the container and the calling
processes keyring is inherited.
Fixes #818
Signed-off-by: Michael Crosby crosbymichael@gmail.com