Adjust man pages for create start split#878
Merged
cyphar merged 1 commit intoopencontainers:masterfrom Aug 24, 2016
Merged
Conversation
| run create and run a container | ||
| spec create a new specification file | ||
| start create and run a container | ||
| start start signals a created container to execute the user defined process |
Contributor
There was a problem hiding this comment.
might be better phrased as start executes the user defined process in a created container
Contributor
Author
There was a problem hiding this comment.
The initial phrase seems more accurate about what start does, but I'm ok with both, since it's Michael's words, @crosbymichael WDYT?
Member
There was a problem hiding this comment.
As an aside, we shouldn't repeat the command name as the first word. So "signals a created container to start execution".
Member
There was a problem hiding this comment.
whatever is more clear is good with me if you want to change both instances of the sentence
Signed-off-by: Qiang Huang <h.huangqiang@huawei.com>
hqhq
force-pushed
the
adjust_man_for_run_create
branch
2 times, most recently
from
c02590f to
c669b8d
Compare
Contributor
Author
|
Updated. PTAL. |
Member
|
LGTM |
1 similar comment
Member
|
LGTM |
cyphar
added a commit
that referenced
this pull request
Aug 24, 2016
Closes #878 [Adjust man pages for create start split].
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qiang Huang h.huangqiang@huawei.com