-
Notifications
You must be signed in to change notification settings - Fork 17
fix(signals): support Celery protocol v2 in create_user_task #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(signals): support Celery protocol v2 in create_user_task #422
Conversation
|
Thanks for the pull request, @asajjad2! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
|
asajjad2's work should be covered by the MIT entity agreement. I added him to the MIT Staff and GitHub Details google sheet back in February. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #422 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 17 +1
Lines 435 460 +25
Branches 47 51 +4
=========================================
+ Hits 435 460 +25
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@asajjad2 Looks like there are some test and quality check failures. Can you have a look. The issue with your CLA should be fixed a little later today when the batch job runs. |
|
@asajjad2 |
|
@asajjad2 can you try re-running the tests on this PR? |
refactor: pep-8 conformation
6dc46e1 to
5ca72bb
Compare
|
@e0d the tests are failing with the error:
Is there an issue with openedx's Billing and Plans? Or is this on MIT? |
|
@pdpinch I think this was an issue on our side caused by a mysterious .03 charge. I've re-run them. It does look like there's a commit lint issue. |
…and extract_proto2_embed
What are the relevant tickets?
#232, #6807
Description (What does it do?)
This PR fixes a compatibility issue with the create_user_task signal handler when using Celery's task message protocol version 2, which has been the default for several years.
Currently, the signal handler fails with the following error:
TypeError: tuple indices must be integers or slices, not strThis occurs because the handler expects a protocol v1-style task body (a dictionary), while protocol v2 passes the body as a tuple. Although the exception is caught and logged internally by Celery, it might be preventing UserTaskStatus from being created reliably in affected cases.
Changes
The changes mainly follows the workaround suggested in the issue: