-
Notifications
You must be signed in to change notification settings - Fork 17
fix: update id parameter name in celery-v2 headers #433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update id parameter name in celery-v2 headers #433
Conversation
|
Thanks for the pull request, @asajjad2! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
UsamaSadiq
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@asajjad2 let's also bump the package version and update the CHANGELOG within the same PR too.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #433 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 460 460
Branches 51 51
=========================================
Hits 460 460
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
https://pypi.org/project/django-user-tasks/3.4.3/ new version released on PyPI. |
What are the relevant tickets?
#7982, #422
Description (What does it do?)
This PR fixes an incorrect parameter name in the extract_proto2_headers function that I introduced in my previous PR. I mistakenly used
task_idas a parameter when the actual Celery protocol v2 specification uses id for the task identifier in headers (as documented in the official Celery protocol docs). This was causingTypeError: extract_proto2_headers() missing 1 required positional argument: 'task_id'in production.The fix removes the incorrect
task_idparameter and uses the correctidparameter as specified by Celery's protocol v2.