Adds Yangtze River map (Upside Down U-shaped pipe river map)

[crunchybbb2]

Before opening a PR: discuss new features on Discord first, and file bugs or small improvements as issues. You must be assigned to an approved issue — unsolicited PRs will be auto-closed.

Add approved & assigned issue number here:

Resolves #4767 (issue number)

Description:

Adds Yangtze River crescent pipe map using impassable terrain

• Is a crescent shaped river map based on a portion of river near the mouth of Yangtze River in China
• 9 Nations based on cities (No additional nations)
• 1.87mil land area. Slightly larger than mississippi (?)

Please complete the following:

• I have added screenshots for all UI updates
• I process any text displayed to the user through translateText() and I've added it to the en.json file
• I have added relevant tests to the test directory

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME crunchybbbbb

[coderabbitai]

Walkthrough

The PR adds the Yangtze River map with metadata, nine Chinese nation locations, a thumbnail, English localization, and registration in the game map enum and metadata collection.

Changes

Yangtze River map

Layer / File(s)	Summary
Map content and metadata map-generator/assets/maps/yangtzeriver/info.json, resources/maps/yangtzeriver/manifest.json, resources/maps/yangtzeriver/thumbnail.webp	Adds Yangtze River map configuration, dimensions, categories, multiplayer frequency, nine nation locations, and thumbnail content.
Map localization and registry resources/lang/en.json, src/core/game/Maps.gen.ts	Adds the “Yangtze River” English translation and registers the map in GameMapType and the exported maps collection.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant MapRegistry
  participant Localization
  participant MapManifest
  MapRegistry->>Localization: resolve map.yangtzeriver
  MapRegistry->>MapManifest: load Yangtze River metadata
  MapManifest-->>MapRegistry: return dimensions and starting locations

Loading

Possibly related PRs

• openfrontio/OpenFrontIO#3920 — Adds a regional map through metadata, localization, manifests, and game registration.
• openfrontio/OpenFrontIO#4176 — Adds river map content with nation locations and map registration.
• openfrontio/OpenFrontIO#4677 — Adds a map through metadata, assets, localization, and Maps.gen.ts.

Suggested labels: Maps

Suggested reviewers: evanpelle

Poem

A river curls across the map,
Nine nations mark its winding path.
New and Asian tags now gleam,
A thumbnail anchors the stream.
Yangtze joins the map registry.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Linked Issues check	❓ Inconclusive	Metadata shows nine city-based locations, but geometry, impassable terrain, and land area require excluded image and binary map files.	Verify image.png and map.bin, map4x.bin, map16x.bin, which were excluded by the !/*.png and !/*.bin filters.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added Yangtze River map and its pipe-shaped river layout.
Description check	✅ Passed	The description directly explains the Yangtze River map, its shape, terrain, nations, and approximate land area.
Out of Scope Changes check	✅ Passed	The map metadata, localization, manifest, thumbnail, and generated registry entry support the linked Yangtze River map objective.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing Touches 💡 1

🛠️ Fix failing CI checks 💡

• Fix failing CI checks

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/core/game/Maps.gen.ts`:
- Line 121: Add or update the map registry integration test covering the
YangtzeRiver entry in Maps.gen.ts. Verify its ID, metadata, and localization key
resolve correctly through the registry, following the existing test patterns for
other maps.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b084ae8d-9b10-45ca-a48e-13e78e93139f

📥 Commits

Reviewing files that changed from the base of the PR and between 2f48ae9 and 3e91e98.

⛔ Files ignored due to path filters (4)

• map-generator/assets/maps/yangtzeriver/image.png is excluded by !**/*.png
• resources/maps/yangtzeriver/map.bin is excluded by !**/*.bin
• resources/maps/yangtzeriver/map16x.bin is excluded by !**/*.bin
• resources/maps/yangtzeriver/map4x.bin is excluded by !**/*.bin

📒 Files selected for processing (5)

• map-generator/assets/maps/yangtzeriver/info.json
• resources/lang/en.json
• resources/maps/yangtzeriver/manifest.json
• resources/maps/yangtzeriver/thumbnail.webp
• src/core/game/Maps.gen.ts