Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8245654: Add Certigna Root CA #10030

Closed
wants to merge 7 commits into from
Closed

8245654: Add Certigna Root CA #10030

wants to merge 7 commits into from

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Aug 25, 2022

This fix adds Certigna root CA to cacerts trust store.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10030/head:pull/10030
$ git checkout pull/10030

Update a local copy of the PR:
$ git checkout pull/10030
$ git pull https://git.openjdk.org/jdk pull/10030/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10030

View PR using the GUI difftool:
$ git pr show -t 10030

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10030.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2022

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2022

@rhalade The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Aug 25, 2022
@rhalade rhalade marked this pull request as ready for review August 25, 2022 20:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2022
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2022

Webrevs

@rhalade rhalade changed the title 8247698: Add Certigna Root CAs 8245654: Add Certigna Root CAs Aug 25, 2022
@openjdk
Copy link

openjdk bot commented Aug 26, 2022

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8245654: Add Certigna Root CA

Reviewed-by: xuelei, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 69 new commits pushed to the master branch:

  • 3baad06: 8295953: Use enhanced-for cycle instead of Enumeration in sun.security
  • ba303c0: 8295893: Improve printing of Constant Pool Cache Entries
  • f8b2574: 8296137: diags-examples.xml is broken
  • 00d22f6: 8279164: Disable TLS_ECDH_* cipher suites
  • d634dde: 8295354: Remove G1 incremental non-copy time calculation
  • 8836b92: 8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException
  • 51f8e9b: 8296443: NMT: Remove cmdline_tracking_level handling code
  • 087cedc: 8295261: RISC-V: Support ReductionV instructions for Vector API
  • 556377a: 8296270: Memory leak in ClassLoader::setup_bootstrap_search_path_impl
  • c2f7638: 8296335: Fix accessibility manual test instruction
  • ... and 59 more: https://git.openjdk.org/jdk/compare/50d91a31d495adf8e189d0188918f4ff22f93876...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 26, 2022
@seanjmullan
Copy link
Member

Can we change the issue title to "Add Certigna Root CA" since only one root is being added?

@rhalade rhalade changed the title 8245654: Add Certigna Root CAs 8245654: Add Certigna Root CA Aug 26, 2022
@rhalade
Copy link
Member Author

rhalade commented Aug 26, 2022

I have update the bug summary as suggested by Sean.

@rhalade
Copy link
Member Author

rhalade commented Aug 26, 2022

I put this on hold to debug a potential issue I am seeing.

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 27, 2022

@rhalade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@lilgallon
Copy link

lilgallon commented Oct 17, 2022

Hi @lilgallon, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user lilgallon for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

Issuer: CN=Certigna, O=Dhimyotis, C=FR
Serial number: fedce3010fc948ff
Valid from: Fri Jun 29 15:13:05 GMT 2007 until: Tue Jun 29 15:13:05 GMT 2027
Signature algorithm name: SHA1withRSA (weak)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't include "(weak)" in this line. The signature algorithm of root certificates is not a security issue, since the certificate fingerprint has been verified and the public key is trusted directly.

@rhalade
Copy link
Member Author

rhalade commented Nov 7, 2022

I am closing this pull request as we still don't have OCA signed from CA.

@rhalade rhalade closed this Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Pull request is ready to be integrated rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants