-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8245654: Add Certigna Root CA #10030
Conversation
👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into |
Webrevs
|
@rhalade This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 69 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Can we change the issue title to "Add Certigna Root CA" since only one root is being added? |
I have update the bug summary as suggested by Sean. |
I put this on hold to debug a potential issue I am seeing. |
@rhalade This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
Hi @lilgallon, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user lilgallon for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.
Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use. |
Issuer: CN=Certigna, O=Dhimyotis, C=FR | ||
Serial number: fedce3010fc948ff | ||
Valid from: Fri Jun 29 15:13:05 GMT 2007 until: Tue Jun 29 15:13:05 GMT 2027 | ||
Signature algorithm name: SHA1withRSA (weak) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't include "(weak)" in this line. The signature algorithm of root certificates is not a security issue, since the certificate fingerprint has been verified and the public key is trusted directly.
I am closing this pull request as we still don't have OCA signed from CA. |
This fix adds Certigna root CA to cacerts trust store.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10030/head:pull/10030
$ git checkout pull/10030
Update a local copy of the PR:
$ git checkout pull/10030
$ git pull https://git.openjdk.org/jdk pull/10030/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 10030
View PR using the GUI difftool:
$ git pr show -t 10030
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10030.diff