8279164: Disable TLS_ECDH_* cipher suites

[seanjmullan]

This change will disable TLS_ECDH_* cipher suites by default. These cipher suites do not preserve forward secrecy and are rarely used in practice. See the CSR for more details and rationale.

Users will still be able to enable the suites (at their own risk) by removing "ECDH" from the jdk.tls.disabledAlgorithms security property.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires a CSR request to be approved

Issues

• JDK-8279164: Disable TLS_ECDH_* cipher suites
• JDK-8296300: Disable TLS_ECDH_* cipher suites (CSR)

Reviewers

• Xue-Lei Andrew Fan (@XueleiFan - Reviewer) ⚠️ Review applies to 897f5603
• Rajan Halade (@rhalade - Reviewer) ⚠️ Review applies to 897f5603
• Bradford Wetmore (@bradfordwetmore - Reviewer) ⚠️ Review applies to 0aa21bdc

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk pull/10969/head:pull/10969
$ git checkout pull/10969

Update a local copy of the PR:
$ git checkout pull/10969
$ git pull https://git.openjdk.org/jdk pull/10969/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 10969

View PR using the GUI difftool:
$ git pr show -t 10969

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/10969.diff

[bridgekeeper]

👋 Welcome back mullan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@seanjmullan The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (5a557059)
• 01: Full - Incremental (0aa21bdc)
• 00: Full (897f5603)

[XueleiFan]

Looks good to me.

[ecki]

Should probably also be mentioned as planned on the Ora crypto roadmap or will it only be added at release time?

[seanjmullan]

Should probably also be mentioned as planned on the Ora crypto roadmap or will it only be added at release time?

Eventually. This is to first get this change into a feature release.

[openjdk]

@seanjmullan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8279164: Disable TLS_ECDH_* cipher suites

Reviewed-by: xuelei, rhalade, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 11 new commits pushed to the master branch:

• 22347e4: 8277775: Fixup bugids in RemoveDropTargetCrashTest.java - add 4357905
• 1231682: 8296305: Remove unimplemented deoptimized_wrt_marked_nmethods
• 3378bfe: 8296224: G1: Remove unnecessary update in VM_G1CollectForAllocation
• 8ee0f7d: 8296231: Fix MEMFLAGS for CHeapBitMaps
• bd729e6: 8296380: IGV: Shortcut for quick search not working
• c116ae7: 8295967: RISC-V: Support negVI/negVL instructions for Vector API
• 9d3b4ef: 8296108: (tz) Update Timezone Data to 2022f
• 4d1bc1b: 8296285: test/hotspot/jtreg/compiler/intrinsics/TestFloatIsFinite.java fails after JDK-8280378
• 0349803: 8295319: pending_cards_at_gc_start doesn't include cards in thread buffers
• 8f6c048: 8296337: CDS SharedArchiveConsistency tests fail after JDK-8296157
• ... and 1 more: https://git.openjdk.org/jdk/compare/f43bb9feaa03008bad9708a4d7ed850d2532e102...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[bradfordwetmore]

LGTM other than the typos.

[bradfordwetmore]

Thanks.

[seanjmullan]

/integrate

[openjdk]

Going to push as commit 00d22f6.
Since your change was applied there have been 29 commits pushed to the master branch:

• d634dde: 8295354: Remove G1 incremental non-copy time calculation
• 8836b92: 8296226: Add constructors (String,Throwable) and (Throwable) to InvalidParameterException
• 51f8e9b: 8296443: NMT: Remove cmdline_tracking_level handling code
• 087cedc: 8295261: RISC-V: Support ReductionV instructions for Vector API
• 556377a: 8296270: Memory leak in ClassLoader::setup_bootstrap_search_path_impl
• c2f7638: 8296335: Fix accessibility manual test instruction
• 91292d5: 8286301: Port JEP 425 to RISC-V
• 581133a: 8294696: BufferedInputStream.transferTo should drain buffer when mark set
• d8573b2: 8294488: Delete KCMS transforms wrappers
• f857f79: 8015739: Background of JInternalFrame is located out of JInternalFrame
• ... and 19 more: https://git.openjdk.org/jdk/compare/f43bb9feaa03008bad9708a4d7ed850d2532e102...master

Your commit was automatically rebased without conflicts.

[openjdk]

@seanjmullan Pushed as commit 00d22f6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.