Conversation
amueller
reviewed
Oct 13, 2017
| for xmlquality in qualities: | ||
| name = xmlquality['oml:name'] | ||
| if xmlquality['oml:value'] is None: | ||
| if 'oml:value' not in xmlquality: |
Contributor
There was a problem hiding this comment.
now about
if xmlquality.get('oml:value', None) is None:
value = float('NaN')
Codecov Report
@@ Coverage Diff @@
## develop #361 +/- ##
========================================
Coverage 89.69% 89.69%
========================================
Files 32 32
Lines 2543 2543
========================================
Hits 2281 2281
Misses 262 262
Continue to review full report at Codecov.
|
amueller
reviewed
Oct 13, 2017
|
|
||
| if xmlquality.get('oml:value', None) is None: | ||
| value = float('NaN') | ||
| elif 'oml:value' not in xmlquality: |
Contributor
There was a problem hiding this comment.
you don't need this line ;) that was kind of the point...
amueller
approved these changes
Oct 13, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.