Skip to content

Fix keyerror in quality lookup #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfeurer merged 3 commits into from
Oct 13, 2017
Merged

Fix keyerror in quality lookup #361

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9e7f812
Fix keyerror in quality lookup
mfeurer Oct 13, 2017
3dcc087
include @amueller s suggestion
mfeurer Oct 13, 2017
1e42e7b
remove unnecessary line
mfeurer Oct 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions openml/datasets/dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,13 +455,12 @@ def _data_features_supported(self):
return True



def _check_qualities(qualities):
if qualities is not None:
qualities_ = {}
for xmlquality in qualities:
name = xmlquality['oml:name']
if xmlquality['oml:value'] is None:
if xmlquality.get('oml:value', None) is None:
value = float('NaN')
elif xmlquality['oml:value'] == 'null':
value = float('NaN')
Expand Down