add validation for strings in datasets#822
Merged
mfeurer merged 4 commits intoopenml:developfrom Oct 14, 2019
Merged
Conversation
mfeurer
approved these changes
Oct 14, 2019
Member
|
Wouldn't it be better to locally check the XML on the XSD schema (available on line)? That keeps the burden to maintain the schema in one place. |
Collaborator
|
Yeah, Andy opened an issue for that, too (#821), but I think for the time being this one was easier to implement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add some basic validation for strings in datasets.
Adding tests now.