Skip to content

only check strings for new datasets#824

Merged
mfeurer merged 1 commit intoopenml:developfrom
amueller:less_string_checking
Oct 15, 2019
Merged

only check strings for new datasets#824
mfeurer merged 1 commit intoopenml:developfrom
amueller:less_string_checking

Conversation

@amueller
Copy link
Copy Markdown
Contributor

Follow up on #822: old datasets violate this restriction (thought I guess not the restrictions for the name?)

Does that need a test? It would maybe be easiest to roll back the schema to what it was?

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #824 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #824      +/-   ##
===========================================
+ Coverage    88.05%   88.05%   +<.01%     
===========================================
  Files           36       36              
  Lines         4243     4244       +1     
===========================================
+ Hits          3736     3737       +1     
  Misses         507      507
Impacted Files Coverage Δ
openml/datasets/dataset.py 87.5% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4853d7c...6b09e82. Read the comment docs.

@mfeurer mfeurer merged commit 5b0d4dc into openml:develop Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants