Skip to content

Document job creation response changes for TiesDb#165

Merged
brosenberg42 merged 2 commits into
developfrom
tiesdb-job-resp
May 4, 2023
Merged

Document job creation response changes for TiesDb#165
brosenberg42 merged 2 commits into
developfrom
tiesdb-job-resp

Conversation

@brosenberg42

@brosenberg42 brosenberg42 commented Apr 28, 2023

Copy link
Copy Markdown
Member

@brosenberg42
brosenberg42 requested a review from jrobble April 28, 2023 17:54
@brosenberg42 brosenberg42 self-assigned this Apr 28, 2023

@jrobble jrobble left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @brosenberg42)


docs/site/html/REST-API.html line 186 at r1 (raw file):

        <br/>
    </div>
    <div class='footer'>Last updated on: April 3, 2023</div>

Please update this date.


docs/site/html/REST-API.html line 825 at r1 (raw file):

                        <td style='width:20%;'>string</td>
                        <td style='width:40%;'>
                            If a compatible job is found in TiesDb and the job is not configured to

Please mention that theMEDIA_HASH and MIME_TYPE media metadata need to be provided in the job request in order to skip media inspection in order to return outputObjectUri.

@brosenberg42 brosenberg42 left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @jrobble)


docs/site/html/REST-API.html line 825 at r1 (raw file):

Previously, jrobble (Jeff Robble) wrote…

Please mention that theMEDIA_HASH and MIME_TYPE media metadata need to be provided in the job request in order to skip media inspection in order to return outputObjectUri.

Done.

@jrobble jrobble left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @brosenberg42)

@jrobble jrobble left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @brosenberg42)

@brosenberg42
brosenberg42 merged commit 083f8c6 into develop May 4, 2023
@brosenberg42
brosenberg42 deleted the tiesdb-job-resp branch May 4, 2023 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants