-
Notifications
You must be signed in to change notification settings - Fork 581
Bug 2106086: operator/ingress: Fix healthCheckInterval pattern #1223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 2106086: operator/ingress: Fix healthCheckInterval pattern #1223
Conversation
Reject values for healthCheckInterval such as "0abc". This commit fixes bug 2106086. https://bugzilla.redhat.com/show_bug.cgi?id=2106086 * operator/v1/types_ingress.go (IngressControllerTuningOptions): Fix validation for healthCheckInterval. * operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml: Regenerate.
|
Hello @Miciah! Some important instructions when contributing to openshift/api: For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard
OR
Who should apply these qe/docs/px labels?
|
|
@Miciah: This pull request references Bugzilla bug 2106086, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@Miciah: This pull request references Bugzilla bug 2106086, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm working out whether we have time to fix for 4.11.0. If we do, then we can release this hold. If we do not, then we cannot merge this. |
|
/bugzilla refresh |
|
@Miciah: This pull request references Bugzilla bug 2106086, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test verify |
|
@Miciah: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
|
@deads2k: once the present PR merges, I will cherry-pick it on top of release-4.11 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Miciah: All pull requests linked via external trackers have merged: Bugzilla bug 2106086 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@deads2k: new pull request created: #1224 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Reject values for
healthCheckIntervalsuch as "0abc".operator/v1/types_ingress.go(IngressControllerTuningOptions): Fix validation forhealthCheckInterval.operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml: Regenerate.