Skip to content

[release-4.11] Bug 2106116: operator/ingress: Fix healthCheckInterval pattern #1224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 12, 2022
Merged

[release-4.11] Bug 2106116: operator/ingress: Fix healthCheckInterval pattern #1224

merged 1 commit into from
Jul 12, 2022

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 11, 2022

This is an automated cherry-pick of #1223

/assign deads2k

@Miciah
operator/ingress: Fix healthCheckInterval pattern
12e3d35 
Reject values for healthCheckInterval such as "0abc".

This commit fixes bug 2106086.

https://bugzilla.redhat.com/show_bug.cgi?id=2106086

* operator/v1/types_ingress.go (IngressControllerTuningOptions): Fix
validation for healthCheckInterval.
* operator/v1/0000_50_ingress-operator_00-ingresscontroller.crd.yaml:
Regenerate.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 11, 2022
Merged
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

Hello @openshift-cherrypick-robot! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

For merging purposes, this repository follows the no-Feature-Freeze process which means that in addition to the standard lgtm and approved labels this repository requires either:

bugzilla/valid-bug - applied if your PR references a valid bugzilla bug

OR

qe-approved, docs-approved, and px-approved - these labels can be applied by anyone in the openshift org via the /label command.

Who should apply these qe/docs/px labels?

  • For a no-Feature-Freeze team who is merging a feature before code freeze, they need to get those labels applied to their api repo PR by the appropriate teams (i.e. qe, docs, px)
  • For a Feature Freeze (traditional) team who is merging a feature before FF, they can self-apply the labels (via /label commands), they are basically irrelevant for those teams
  • For a Feature Freeze team who is merging a feature after FF, the PR should be rejected barring an exception

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

@openshift-cherrypick-robot: Bugzilla bug 2106086 has been cloned as Bugzilla bug 2106116. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2106116: operator/ingress: Fix healthCheckInterval pattern

In response to this:

[release-4.11] Bug 2106086: operator/ingress: Fix healthCheckInterval pattern

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.11] Bug 2106086: operator/ingress: Fix healthCheckInterval pattern [release-4.11] Bug 2106116: operator/ingress: Fix healthCheckInterval pattern Jul 11, 2022
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 11, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2106116, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2106086 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2106086 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @lihongan

In response to this:

[release-4.11] Bug 2106116: operator/ingress: Fix healthCheckInterval pattern

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested review from jwforres, lihongan and sjenning July 11, 2022 19:21
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 11, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@knobunc
Copy link
Contributor

knobunc commented Jul 12, 2022

/approve

@knobunc knobunc added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 12, 2022
@knobunc
Copy link
Contributor

knobunc commented Jul 12, 2022

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: knobunc, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2022
@openshift-ci openshift-ci bot merged commit 2647eb3 into openshift:release-4.11 Jul 12, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 12, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2106116 has been moved to the MODIFIED state.

In response to this:

[release-4.11] Bug 2106116: operator/ingress: Fix healthCheckInterval pattern

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot mentioned this pull request Jul 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lihongan lihongan Awaiting requested review from lihongan

@jwforres jwforres Awaiting requested review from jwforres

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@deads2k deads2k

@knobunc knobunc

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@openshift-cherrypick-robot @knobunc @deads2k @Miciah